Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump direct dependencies #4196

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Bump direct dependencies #4196

merged 4 commits into from
Jan 21, 2025

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jan 17, 2025

What?

As part of the regular release process #4162, we want to bump the direct dependencies.

Report

Skipped

These updates are skipped, as,

These ones require Go 1.23:

And this one already has an active PR (#4151):

❤️ I'm open to suggestions. Thanks.

Related

@inancgumus inancgumus self-assigned this Jan 17, 2025
@inancgumus inancgumus marked this pull request as ready for review January 17, 2025 19:57
@inancgumus inancgumus requested a review from a team as a code owner January 17, 2025 19:57
@inancgumus inancgumus requested review from mstoykov and joanlopez and removed request for a team January 17, 2025 19:57
@inancgumus inancgumus force-pushed the bump/direct-deps branch 2 times, most recently from 9bc3f9f to 288c429 Compare January 21, 2025 14:56
mstoykov
mstoykov previously approved these changes Jan 21, 2025
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the details changelog.

I kind of don't want to update otel this late in the cycle. There were some problems hte previous times IIRC.

cc @codebien and @olegbespalov as I think they might know something relevant.
I do wonder if we should not update otel from here but from the output as that might be the most fragile part currently. 🤔 So maybe I should remove it from dependabot here and move it to there.

@codebien
Copy link
Contributor

I do wonder if we should not update otel from here but from the output as that might be the most fragile part currently

@mstoykov It's fine for me, but we have to enable Dependabot on the OTel repo to not keep it outdated for a long time.

@olegbespalov
Copy link
Contributor

I believe OTEL is currently more important in context of browser, which uses it (cc @ankur22 ), xk6-opentelemetry output versions just aligned with what k6 has

@mstoykov
Copy link
Contributor

I wonder if this doesn't break the otel output though . I doubt any of those updates help anything browser uses either way. So skipping to update them at the end of the cycle seems like the more safe bet.

@ankur22
Copy link
Contributor

ankur22 commented Jan 21, 2025

So skipping to update them at the end of the cycle seems like the more safe bet.

Agreed, i think it's best to update deps at the beginning of the cycle (in general, actually, i'm not a fan of depandabot, and i'd prefer to update once at the beginning and not half way or at the end of the cycle).

@inancgumus
Copy link
Member Author

@mstoykov @codebien @olegbespalov @ankur22 I've removed the Otel update from this PR.

@inancgumus inancgumus requested a review from mstoykov January 21, 2025 15:46
@inancgumus inancgumus merged commit a0277c9 into master Jan 21, 2025
28 checks passed
@inancgumus inancgumus deleted the bump/direct-deps branch January 21, 2025 16:17
@inancgumus inancgumus added this to the v0.57.0 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants