-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump direct dependencies #4196
Bump direct dependencies #4196
Conversation
9bc3f9f
to
288c429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the details changelog.
I kind of don't want to update otel this late in the cycle. There were some problems hte previous times IIRC.
cc @codebien and @olegbespalov as I think they might know something relevant.
I do wonder if we should not update otel from here but from the output as that might be the most fragile part currently. 🤔 So maybe I should remove it from dependabot here and move it to there.
288c429
to
5237d84
Compare
@mstoykov It's fine for me, but we have to enable Dependabot on the OTel repo to not keep it outdated for a long time. |
I believe OTEL is currently more important in context of browser, which uses it (cc @ankur22 ), xk6-opentelemetry output versions just aligned with what k6 has |
I wonder if this doesn't break the otel output though . I doubt any of those updates help anything browser uses either way. So skipping to update them at the end of the cycle seems like the more safe bet. |
Agreed, i think it's best to update deps at the beginning of the cycle (in general, actually, i'm not a fan of depandabot, and i'd prefer to update once at the beginning and not half way or at the end of the cycle). |
5237d84
to
1386d5e
Compare
@mstoykov @codebien @olegbespalov @ankur22 I've removed the Otel update from this PR. |
What?
As part of the regular release process #4162, we want to bump the direct dependencies.
Report
CompareType
.Payload
field.Skipped
These updates are skipped, as,
These ones require Go 1.23:
And this one already has an active PR (#4151):
❤️ I'm open to suggestions. Thanks.
Related