Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the expected char with the default output #2934

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Feb 24, 2023

It fixes the ui print output: engine restoring the expected text output: - when there isn't an explicit set from the user.

@codebien codebien self-assigned this Feb 24, 2023
@codebien codebien added this to the v0.44.0 milestone Feb 24, 2023
@codebien codebien marked this pull request as ready for review February 24, 2023 09:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #2934 (5734d2c) into master (26ec301) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 5734d2c differs from pull request most recent head 834e55d. Consider uploading reports for the commit 834e55d to get more accurate results

@@            Coverage Diff             @@
##           master    #2934      +/-   ##
==========================================
+ Coverage   76.86%   76.89%   +0.02%     
==========================================
  Files         225      225              
  Lines       16895    16898       +3     
==========================================
+ Hits        12987    12994       +7     
+ Misses       3076     3072       -4     
  Partials      832      832              
Flag Coverage Δ
ubuntu 76.83% <100.00%> (+0.02%) ⬆️
windows 76.71% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/ui.go 70.35% <100.00%> (+1.47%) ⬆️
metrics/engine/ingester.go 85.18% <100.00%> (ø)
metrics/metric_type.go 78.94% <0.00%> (-3.51%) ⬇️
js/modules/k6/ws/ws.go 86.08% <0.00%> (-0.58%) ⬇️
output/csv/output.go 70.28% <0.00%> (+1.44%) ⬆️
lib/executor/vu_handle.go 95.32% <0.00%> (+1.86%) ⬆️
output/json/json.go 94.80% <0.00%> (+2.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

olegbespalov
olegbespalov previously approved these changes Feb 24, 2023
imiric
imiric previously approved these changes Feb 24, 2023
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you have k6 run --out json or --out cloud? you'd see something like output: -, cloud, right?

@imiric imiric self-requested a review February 24, 2023 10:18
@olegbespalov olegbespalov self-requested a review February 24, 2023 10:29
@codebien codebien dismissed stale reviews from imiric and olegbespalov via 834e55d February 24, 2023 12:08
@codebien codebien requested a review from na-- February 24, 2023 12:16
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fine now 😅

Thanks for the test 👍

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇 ❤️

@codebien codebien merged commit 2305316 into master Feb 24, 2023
@codebien codebien deleted the fix-default-out-ui branch February 24, 2023 13:52
@na-- na-- modified the milestones: v0.44.0, v0.43.1 Feb 25, 2023
@na-- na-- mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants