Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and expand e2e tests for k6 run --out cloud and k6 cloud #2864

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

na--
Copy link
Member

@na-- na-- commented Jan 20, 2023

This PR only has tests of the existing behavior, it doesn't have any actual code changes. Those will come in a separate PR.

@github-actions github-actions bot requested review from imiric and mstoykov January 20, 2023 05:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Merging #2864 (106404d) into master (4b82b55) will increase coverage by 0.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2864      +/-   ##
==========================================
+ Coverage   76.04%   76.89%   +0.85%     
==========================================
  Files         217      217              
  Lines       16604    16604              
==========================================
+ Hits        12626    12768     +142     
+ Misses       3201     3029     -172     
- Partials      777      807      +30     
Flag Coverage Δ
ubuntu 76.74% <ø> (+0.84%) ⬆️
windows 76.59% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1/status_routes.go 51.02% <0.00%> (-4.09%) ⬇️
metrics/metric_type.go 78.94% <0.00%> (-3.51%) ⬇️
lib/executor/vu_handle.go 95.32% <0.00%> (+1.86%) ⬆️
core/local/local.go 91.91% <0.00%> (+2.20%) ⬆️
cloudapi/config.go 88.88% <0.00%> (+2.22%) ⬆️
lib/execution.go 92.66% <0.00%> (+2.75%) ⬆️
cmd/ui.go 69.89% <0.00%> (+4.08%) ⬆️
api/v1/metric.go 68.18% <0.00%> (+4.54%) ⬆️
cloudapi/api.go 47.72% <0.00%> (+23.86%) ⬆️
cmd/cloud.go 70.94% <0.00%> (+57.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@na-- na-- requested a review from codebien January 20, 2023 11:19
codebien
codebien previously approved these changes Jan 20, 2023
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@na-- na-- merged commit 16635b1 into master Jan 23, 2023
@na-- na-- deleted the cloud-e2e-tests branch January 23, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants