Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http lint fixes #2845

Merged
merged 8 commits into from
Jan 12, 2023
Merged

Http lint fixes #2845

merged 8 commits into from
Jan 12, 2023

Conversation

mstoykov
Copy link
Contributor

No description provided.

@github-actions github-actions bot requested review from codebien and oleiade January 11, 2023 10:15
@mstoykov
Copy link
Contributor Author

There is way more work on this, but I decided to stop here as I feel like this getting bigger will make it harder to review and merge.

I highly recommend looking this commit by commit as the commits are very atomic and usually 1 file. When they touch 2+ files they are usually simple "move this out" or renames/refactors of helper functions.

I am likely to do more work on this along #2825

@mstoykov mstoykov added this to the v0.43.0 milestone Jan 11, 2023
Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can tell 🤞🏻 👏🏻

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstoykov mstoykov merged commit 60b8b15 into master Jan 12, 2023
@mstoykov mstoykov deleted the httpLintFixes branch January 12, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants