Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goja async await #2830

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Goja async await #2830

merged 3 commits into from
Jan 9, 2023

Conversation

mstoykov
Copy link
Contributor

No description provided.

@mstoykov mstoykov mentioned this pull request Dec 21, 2022
@mstoykov mstoykov added this to the v0.43.0 milestone Dec 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #2830 (96d5f3d) into master (613fe8b) will decrease coverage by 0.06%.
The diff coverage is 55.27%.

❗ Current head 96d5f3d differs from pull request most recent head 72aec24. Consider uploading reports for the commit 72aec24 to get more accurate results

@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
- Coverage   76.06%   75.99%   -0.07%     
==========================================
  Files         215      213       -2     
  Lines       16564    16554      -10     
==========================================
- Hits        12599    12581      -18     
- Misses       3197     3200       +3     
- Partials      768      773       +5     
Flag Coverage Δ
ubuntu 75.93% <55.27%> (-0.03%) ⬇️
windows 75.77% <53.72%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/cloud.go 13.40% <0.00%> (+0.57%) ⬆️
cmd/common.go 58.13% <0.00%> (-15.78%) ⬇️
cmd/convert.go 68.29% <0.00%> (ø)
cmd/inspect.go 26.53% <0.00%> (ø)
cmd/login_cloud.go 19.76% <0.00%> (-0.24%) ⬇️
cmd/login_influxdb.go 11.66% <0.00%> (ø)
cmd/pause.go 37.50% <0.00%> (ø)
cmd/resume.go 37.50% <0.00%> (ø)
cmd/scale.go 40.00% <0.00%> (ø)
cmd/stats.go 42.85% <0.00%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mstoykov mstoykov mentioned this pull request Jan 9, 2023
@mstoykov mstoykov marked this pull request as ready for review January 9, 2023 09:02
@github-actions github-actions bot requested review from na-- and olegbespalov January 9, 2023 09:03
@mstoykov mstoykov self-assigned this Jan 9, 2023
olegbespalov
olegbespalov previously approved these changes Jan 9, 2023
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but can we please add a new test or edit an existing test, either in js/ or in the integration test, with even a single async function? 😅

The TC39 tests are awesome, but they are skipped by default. It seems useful to have some minor k6-specific test that will fail in normal go test ./... in our local machines.

@mstoykov
Copy link
Contributor Author

mstoykov commented Jan 9, 2023

It seems useful to have some minor k6-specific test that will fail in normal go test ./... in our local machines.

I would argue those will come when we start adding specific stuff for k6. But have added a small event loop test

@mstoykov mstoykov requested review from na-- and olegbespalov January 9, 2023 15:00
@mstoykov mstoykov merged commit 8418147 into master Jan 9, 2023
@mstoykov mstoykov deleted the gojaAsyncAwait branch January 9, 2023 15:22
@GrayedFox
Copy link

Updated docs with an example using async/await would be the cherry on top! Otherwise cheers, much anticipated by the k6 community I believe ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants