-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goja async await #2830
Goja async await #2830
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2830 +/- ##
==========================================
- Coverage 76.06% 75.99% -0.07%
==========================================
Files 215 213 -2
Lines 16564 16554 -10
==========================================
- Hits 12599 12581 -18
- Misses 3197 3200 +3
- Partials 768 773 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
08609b5
to
3a28337
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but can we please add a new test or edit an existing test, either in js/
or in the integration test, with even a single async
function? 😅
The TC39 tests are awesome, but they are skipped by default. It seems useful to have some minor k6-specific test that will fail in normal go test ./...
in our local machines.
I would argue those will come when we start adding specific stuff for k6. But have added a small event loop test |
Updated docs with an example using async/await would be the cherry on top! Otherwise cheers, much anticipated by the k6 community I believe ⚡ |
No description provided.