Introduce experimental JS modules #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
reviewed
Aug 2, 2022
|
The error you are getting in the tests is due to 1b0e24e . You should probably bump the k6 version in the extension and fix it there for now. |
|
Checklist:
|
oleiade
force-pushed
the
feature/js/experimental_redis
branch
2 times, most recently
from
844cf7b to
7350f8c
Compare
17 tasks
mstoykov
requested changes
Aug 15, 2022
oleiade
force-pushed
the
feature/js/experimental_redis
branch
2 times, most recently
from
0b30c35 to
7b82bcb
Compare
mstoykov
requested changes
Aug 15, 2022
oleiade
force-pushed
the
feature/js/experimental_redis
branch
2 times, most recently
from
c29fe73 to
2cddbe2
Compare
oleiade
changed the title
oleiade
force-pushed
the
feature/js/experimental_redis
branch
from
2cddbe2 to
bdeca6a
Compare
mstoykov
reviewed
Aug 16, 2022
na--
previously approved these changes
Aug 16, 2022
oleiade
force-pushed
the
feature/js/experimental_redis
branch
3 times, most recently
from
ffaf255 to
097b560
Compare
mstoykov
reviewed
Aug 16, 2022
Comment on lines
+47
to
+50
| github.com/cespare/xxhash/v2 v2.1.2 // indirect | ||
| github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f // indirect | ||
| github.com/go-redis/redis/v8 v8.11.5 // indirect | ||
| github.com/mstoykov/k6-taskqueue-lib v0.1.0 // indirect |
There was a problem hiding this comment.
Shouldn't this be in the bottom block 🤔
mstoykov
previously approved these changes
Aug 16, 2022
olegbespalov
previously approved these changes
Aug 16, 2022
mstoykov
previously approved these changes
Aug 16, 2022
na--
previously approved these changes
Aug 16, 2022
This commit imports the latest state of xk6-redis, xk6-websockets, and xk6-timers into k6's core as experimental modules importable under the "k6/experimental" import path. Specifically regarding the redis module: with it comes a single direct dependency, the `redis/v8` library, and two indirect dependencies implied by the former `xxhash` and `go-rendezvous`. This commit's essential files are: * `js/initcontext.go`: exposes the modules under `k6/experimental` * `samples/experimental/*.go`: exposes examples of the experimental module in action * `samples/docker-compose.yml`: allows to spin up a stack for testing the redis module The rest of the files are essentially go module and vendoring plumbing.
oleiade
dismissed stale reviews from na--, mstoykov, and olegbespalov
via
da648a9
oleiade
force-pushed
the
feature/js/experimental_redis
branch
from
a997947 to
da648a9
Compare
|
It's green again 🪴 🌱 |
mstoykov
approved these changes
Aug 16, 2022
olegbespalov
approved these changes
Aug 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This PR makes
xk6-redis,xk6-timersandxk6-websocketsextensions importable under thek6/experimentalimport path. Their code is not imported in k6's codebase, but instead added as dependencies, which allows for more flexibility during their integration and improvement process moving forward.Review
The code of each module themselves was already reviewed in their source extension's context. We'd be more interested in getting feedback on the integration. Modules are importable as
js/modules/k6/experimentalin k6 scripts, but their code remains in their respective k6 extensions, who have been especially structured to permit this import.Don't let the size of the PR scare you, most of it is "just" vendor anyway.
The significant files are:
js/initcontext.go: exposes the modules underk6/experimentalsamples/experimental/*.go: exposes examples of the experimentalmodule in action
samples/docker-compose.yml: allows spinning up a stack for testingthe Redis module
Let me know what you think 🙇🏻