Fix broken tests and add an extra one #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this, setupExecutor() would always call calculate maxPlannedVUs as if the ExecutionSegmnent was 1:1, since it needed to be manually specified in the Options as well as the ExecutionState. So, while the 3/4:1 segment in TestRampingArrivalRateGlobalIters() theoretically was allotted preAllocatedVUs=0 and maxVUs=1, it actually got 2 pre-allocated VUs to play with, and was able to achieve some of its iterations despite the broken test...
Because the parsing of the threshold definitions now happens in cmd/, loadedTest.consolidateDeriveAndValidateConfig() specifically, this Engine test was completely invalid. You could add whatever values you wanted in its thresholds and it will have still passed...
mstoykov
reviewed
Aug 1, 2022
mstoykov
reviewed
Aug 1, 2022
mstoykov
previously approved these changes
Aug 1, 2022
oleiade
previously approved these changes
Aug 1, 2022
mstoykov
approved these changes
Aug 1, 2022
mstoykov
approved these changes
Aug 1, 2022
oleiade
approved these changes
Aug 1, 2022
|
@na-- A test failed but it seems not connected 🤔 |
|
I re-ran it, since I plan to actually merge this with a merge commit, so I don't want any red crosses in the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing a fairly hefty refactoring (#2594 (comment)), I noticed that a couple of the currently existing tests are invalid or broken... 😞 I'll fix them commit by commit here before making another PR with the actual refactoring.