Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean context usage after common.Bind is removed #2593

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Clean context usage after common.Bind is removed #2593

merged 2 commits into from
Jul 7, 2022

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Jul 7, 2022

No description provided.

@github-actions github-actions bot requested review from codebien and na-- July 7, 2022 12:15
@na-- na-- added this to the v0.40.0 milestone Jul 7, 2022
codebien
codebien previously approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

na--
na-- reviewed Jul 7, 2022
View reviewed changes
@mstoykov mstoykov requested review from na-- and codebien July 7, 2022 14:22
na--
na-- approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@mstoykov mstoykov merged commit bfa415c into master Jul 7, 2022
@mstoykov mstoykov deleted the cleanContextFromJS branch July 7, 2022 15:01
@MattDodsonEnglish MattDodsonEnglish mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebien codebien codebien approved these changes

@na-- na-- na-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @codebien @na--