Update goja to include Promise and sourcemap fixes #2197
Conversation
There was a problem hiding this comment.
What happens when you delete this from the pathBasedBlock:
Line 96 in 431d6e8
Looking at the diff, probably this can be removed as well:
Line 98 in 431d6e8
🤔 I wonder if we shouldn't remove all of the blocks? The CI time might be longer, but at least we won't miss any changes or partial implementations of these features
|
@na-- I started by updating it the same way it's in the upstream repo, but got 2k+ failures of all the async code we currently don't disable, so I guess I am gonna wait on that for at least some time as I don't really want to try to figure out what needs to be disabled or have 5k+ failures in hope I catch a regression combing through those :( |
No description provided.