Skip to content

Commit

Permalink
Addressing the leftovers from webcrypto merge
Browse files Browse the repository at this point in the history
  • Loading branch information
olegbespalov committed Feb 20, 2025
1 parent 1017671 commit 90b59cc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/wpt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
with:
go-version: 1.23.x
check-latest: true
# TODO: combine WebPlatform tests checkout & patch into the singe step
# TODO: combine WebPlatform tests checkout & patch into the single step
- name: Run Streams Tests
run: |
set -x
Expand Down
4 changes: 1 addition & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
/pkg-build
/internal/js/tc39/TestTC39
/internal/js/modules/k6/experimental/streams/tests/wpt
/internal/js/modules/k6/webcrypto/tests/wpt/

.vscode
*.sublime-workspace
Expand Down Expand Up @@ -34,6 +35,3 @@ script.js

/packaging/.env
/packaging/*.gpg

# web platform tests
/internal/js/modules/k6/webcrypto/tests/wpt/
8 changes: 4 additions & 4 deletions examples/webcrypto/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
In this directory, you will find examples of how to use the k6's `webcrypto` module in your k6 scripts.

> [!IMPORTANT]
> We do run the tests based on these examples, that's why we have a simple convention for each example:
> We do run the tests based on these examples; that's why we have a simple convention for each example:
>
> * It should do any `console.log`. Since we try to detect that output (log) contain `INFO` keyword.
> * It should NOT `try/catch` exceptions. Since we try to detect if keywords like `"Uncaught"` and `"ERRO"` should not appear in the output (logs).
> * Success condition: Example SHOULD output an `INFO` keyword using `console.log` at least once.
> * Failure condition: Example SHOULD NOT `try/catch` exceptions so that we can detect failures. The log output SHOULD NOT contain any keywords like `"Uncaught"` and `"ERRO"`.
See [`../../js/modules/k6/webcrypto/cmd_run_test.go`](../../js/modules/k6/webcrypto/cmd_run_test.go) for more details.
See [`../../internal/js/modules/k6/webcrypto/cmd_run_test.go`](../../internal/js/modules/k6/webcrypto/cmd_run_test.go) for more details.

0 comments on commit 90b59cc

Please sign in to comment.