-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to disable a rule #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised! 🙌
The verification rule doesn't have a status label, but I was thinking - maybe instead of added a label we could drop opacity to 0.5 and add hover tooltip "disabled" when rule is not enabled.
The reasoning behind this: in most cases all my rules will be enabled and seeing "enabled" label repeated just adds noise. Here's how it could look like:
I like the idea of reducing noise! I've made the changes you suggested @e-fisher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
This PR introduces the ability to disable/enable a test rule. Disable rules will not be generated by the script.
How to Test
Checklist
npm run lint
) and all checks pass.npm test
) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Resolves #313