Set manager as first container in deployment #409
Conversation
This allow for manager container to be the default container when using `kubectl logs` otherwise one need to add `-c manager` in order to get logs from the manager.
|
|
There was a problem hiding this comment.
Hi @TheoBrigitte, thanks for the PR. I've wondered if anyone needs that change with containers but it never came up as an issue before. Technically, it still didn't since this is a PR, not an issue 🙂
I think overall this change shouldn't be breaking but if there are concerns from anyone, please let me know.
On a PR itself: this change needs to be done in Helm chart as well, to remain consistent.
There was a problem hiding this comment.
Thanks for the update @TheoBrigitte! LGTM 🙌
I'll merge this change next week: if there are any concerns about it within a community, please comment here.
AFAIK, the only possible impact is if anyone is referencing containers by index somewhere, like containers[1]. That can happen in kustomizations, for instance.
This sets
managercontainer as default container in theDeployment.This allow for
managercontainer to be the default container shown when usingkubectl logsotherwise one need to add--container=managerin order to get logs from the manager, sincekube-rbac-proxyis the current default.