Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve linting #157

Closed
yorugac opened this issue Oct 7, 2022 · 2 comments · Fixed by #320
Closed

Improve linting #157

yorugac opened this issue Oct 7, 2022 · 2 comments · Fixed by #320
Labels
enhancement New feature or request hacktoberfest maintenance

Comments

@yorugac
Copy link
Collaborator

yorugac commented Oct 7, 2022 •
edited
Loading

Feature Description

Currently, k6-operator uses only yaml-lint for manifests. Add Golang linters.

Suggested Solution (optional)

k6 repo can be used as a main reference.

Already existing or connected issues / PRs (optional)

No response
@yorugac yorugac added enhancement New feature or request maintenance labels Oct 7, 2022
@u5surf
Copy link
Contributor

u5surf commented Oct 23, 2023

@yorugac Hi, I'd like to work on this issue.
Can we use golangci-lint?

u5surf added a commit to u5surf/k6-operator that referenced this issue Oct 23, 2023
@u5surf
ci: add golang lint and fixed. grafana#157
ed7312a
@u5surf u5surf mentioned this issue Oct 23, 2023
Merged
u5surf added a commit to u5surf/k6-operator that referenced this issue Oct 23, 2023
@u5surf
ci: add golang lint and fixed. grafana#157
cd1e922
@yorugac
Copy link
Collaborator Author

yorugac commented Oct 24, 2023

@u5surf sure. As mentioned in description, k6 repo is the reference point - it uses golangci-lint.

yorugac pushed a commit that referenced this issue Oct 26, 2023
@u5surf
ci: add golang lint and fixed. #157 (#320)
12d691e 
* ci: add golang lint and fixed. #157

* Fixed linter

* use the latest version of golangci-lint in github actions
* add the target of lint in Makefile
* fix nolint errcheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add golang lint and fixed. #157 u5surf/k6-operator
2 participants
@yorugac @u5surf