Use default as a picker value for datasource variable
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes sense (but I was part of the above linked discussion). Would be great if another Grafanista could have a look. |
beorn7
approved these changes
Jan 18, 2020
|
Thanks @sh0rez . Nobody else seems to have any objections, so I'm merging. |
bboreham
added a commit
to grafana/cortex-jsonnet
that referenced
this pull request
Aug 18, 2021
Brings in the following changes: - Use default as a picker value for datasource variable grafana/jsonnet-libs#204 - allow table link in new tab grafana/jsonnet-libs#238 - allow setting a default datasource grafana/jsonnet-libs#301 - Add textPanel grafana/jsonnet-libs#341 - make status code label name overrideable in qpsPanel grafana/jsonnet-libs#397 - use $__rate_interval over $__interval grafana/jsonnet-libs#401 - Set shared tooltip to false by default grafana/jsonnet-libs#458 - Use custom 'all' value to avoid massive regexes in queries. grafana/jsonnet-libs#469 https://github.com/grafana/jsonnet-libs/commits/master/grafana-builder/
1 task
bboreham
added a commit
to grafana/cortex-jsonnet
that referenced
this pull request
Aug 18, 2021
Brings in the following changes: - Use default as a picker value for datasource variable grafana/jsonnet-libs#204 - allow table link in new tab grafana/jsonnet-libs#238 - allow setting a default datasource grafana/jsonnet-libs#301 - Add textPanel grafana/jsonnet-libs#341 - make status code label name overrideable in qpsPanel grafana/jsonnet-libs#397 - use $__rate_interval over $__interval grafana/jsonnet-libs#401 - Set shared tooltip to false by default grafana/jsonnet-libs#458 - Use custom 'all' value to avoid massive regexes in queries. grafana/jsonnet-libs#469 https://github.com/grafana/jsonnet-libs/commits/master/grafana-builder/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in kubernetes-monitoring/kubernetes-mixin#307, this changes the selector to go for the 'default' datasource instead of the hardcoded
Prometheus.