Migrate to CustomVariableSupport #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
commented
Apr 8, 2024
| @@ -129,6 +131,7 @@ export class DataSource extends DataSourceWithBackend<SitewiseQuery, SitewiseOpt | |||
| propertyAlias: templateSrv.replace(query.propertyAlias, scopedVars), | |||
| region: templateSrv.replace(query.region || '', scopedVars), | |||
| propertyId: templateSrv.replace(query.propertyId || '', scopedVars), | |||
| assetId: templateSrv.replace(query.assetId || '', scopedVars), | |||
There was a problem hiding this comment.
Without this, we can't use variables as asset ids (it doesn't fetch the properties properly)
iwysiu
requested review from
idastambuk and
kevinwcyu
and removed request for
a team
idastambuk
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Migrates from the deprecated variable support to
CustomVariableSupport. I created an issue to actually design a new proper variable editor for this with resource handlers for the backend and an issue to handle assetId and assetIds more consistently.Which issue(s) this PR fixes:
Fixes #233
Special notes for your reviewer: