Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo] Update for v2.5.0 release #3151

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented May 31, 2024

Upgrading to Tempo v2.5.0

Tempo v2.5.0 Changelog

@ie-pham ie-pham merged commit 96fbbc1 into grafana:main May 31, 2024
6 checks passed
@gangstead
Copy link

This change sent my tempo pod into a crash loop due to permission errors due to this change: grafana/tempo#2265

The fix is mentioned in the PR but not in the release notes. Add securityContext.fsGroup(10001) at the container level (.Values.securityContext, not .Values.tempo.securityContext).

@zalegrala
Copy link
Contributor

I think the change desired is the one from the tempo-distributed chart: https://github.com/grafana/helm-charts/blob/main/charts/tempo-distributed/values.yaml#L68-L70

You will want more than fsGroup since that would only allow you to read the data, and probably fail on writing. Would you like to PR that change @gangstead ?

@gangstead
Copy link

Mine is reading and writing to the volume with just the fsGroup, maybe that's because I'm attaching an extra volume via the extraVolumeMounts?

I'll do some testing to see if I actually understand what's going on and I'll make a PR.

lumiere-bot bot referenced this pull request in coolguy1771/home-ops Jun 8, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [tempo](https://grafana.net)
([source](https://github.com/grafana/helm-charts)) | minor | `1.8.0`
-> `1.9.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>grafana/helm-charts (tempo)</summary>

###
[`v1.9.0`](https://github.com/grafana/helm-charts/releases/tag/tempo-1.9.0)

[Compare
Source](https://github.com/grafana/helm-charts/compare/tempo-1.8.0...tempo-1.9.0)

Grafana Tempo Single Binary Mode

#### What's Changed

- \[tempo] Update for v2.5.0 release by
[@&#8203;ie-pham](https://github.com/ie-pham) in
[https://github.com/grafana/helm-charts/pull/3151](https://github.com/grafana/helm-charts/pull/3151)

**Full Changelog**:
grafana/helm-charts@grafana-agent-operator-0.3.23...tempo-1.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODIuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM4Mi41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants