[tempo] feat: add metrics generator to chart #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielstenboom
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
Signed-off-by: Niels ten Boom <[email protected]>
Signed-off-by: Niels ten Boom <[email protected]>
Signed-off-by: Niels ten Boom <[email protected]>
Signed-off-by: Niels ten Boom <[email protected]>
Signed-off-by: Niels ten Boom <[email protected]>
|
@nielstenboom seems like something went wrong with the docs? The docs for |
Signed-off-by: Niels ten Boom <[email protected]>
The diff was a bit odd, I've moved the variable to the bottom in the config and the diff seems better now 👍 |
zanhsieh
changed the title
BitProcessor
requested changes
Jul 18, 2022
Signed-off-by: zanhsieh <[email protected]>
zanhsieh
approved these changes
Jul 28, 2022
|
@nielstenboom holidays happened ;) - would you be able to resolve the conflicts ? |
Signed-off-by: zanac1986 <[email protected]>
Signed-off-by: zanac1986 <[email protected]>
Signed-off-by: MH <[email protected]>
Signed-off-by: MH <[email protected]>
Signed-off-by: zanac1986 <[email protected]>
BitProcessor
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR adds support to the chart for the new Tempo metrics generator introduced in 1.4
relevant PR: grafana/tempo#1282
relevant issue: grafana/tempo#1303