Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Convert ReferenceLink.test.js to RTL #50338

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

zoltanbedi
Copy link
Member

Which issue(s) this PR fixes:

Fixes #50332

@zoltanbedi zoltanbedi requested a review from a team June 7, 2022 15:03
@zoltanbedi zoltanbedi self-assigned this Jun 7, 2022
@zoltanbedi zoltanbedi added this to the 9.1.0 milestone Jun 7, 2022
@zoltanbedi zoltanbedi added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore labels Jun 7, 2022
@zoltanbedi zoltanbedi requested a review from ashharrison90 June 7, 2022 15:04
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🙌

import ReferenceLink from './ReferenceLink';

describe(ReferenceLink, () => {
const createFocusSpanLinkMock = jest.fn((traceId, spanId) => {
return {
const model: LinkModel = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👌

});

const ref = {
const ref: TraceSpanReference = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👌

@zoltanbedi zoltanbedi merged commit aa74371 into main Jun 7, 2022
@zoltanbedi zoltanbedi deleted the zoltan/referencelink-to-rtl branch June 7, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend enterprise-ok no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert packages/jaeger-ui-components/src/url/ReferenceLink.test.js to RTL
3 participants