MixedDatasource: Shows retrieved data even if a data source fails #27024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugohaggmark
added
area/datasource
area/datasource/frontend
area/panel/data
hugohaggmark
requested review from
torkelo,
peterholmberg,
ryantxu and
mckn
and removed request for
a team,
torkelo and
peterholmberg
hugohaggmark
changed the title
aknuds1
pushed a commit
that referenced
this pull request
Aug 19, 2020
…7024) * MixedDatasource: Shows data for working data sources and error for erroneous * Tests: remove funky import * Tests: fixes types
ryantxu
pushed a commit
that referenced
this pull request
Aug 19, 2020
…7024) * MixedDatasource: Shows data for working data sources and error for erroneous * Tests: remove funky import * Tests: fixes types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes sure that any successful data fetched by MixedDatasource is shown although other data sources are failing. The error will show the first error (enhanced with the data source name) but we could tweak this if we want to show all erroneous data sources in the message.
Which issue(s) this PR fixes:
Fixes #26955
Special notes for your reviewer:
You can use this dashboard with TestData and Postgres as a starting point: https://gist.github.com/hugohaggmark/d6ba274ec21085fa34a358a6f8a2b4a6