Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable forced deletion of GrafanaFolder #1728

Merged
merged 4 commits into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .chainsaw.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/kyverno/chainsaw/main/.schemas/json/configuration-chainsaw-v1alpha1.json
apiVersion: chainsaw.kyverno.io/v1alpha1
apiVersion: chainsaw.kyverno.io/v1alpha2
kind: Configuration
metadata:
name: configuration
spec:
error:
catch:
- describe:
apiVersion: grafana.integreatly.org/v1beta1
kind: grafana-operator
- podLogs:
namespace: grafana-operator-system
tail: 100
timeouts:
assert: 2m0s
cleanup: 3m0s
Expand Down
6 changes: 4 additions & 2 deletions controllers/grafanafolder_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@ func (r *GrafanaFolderReconciler) syncFolders(ctx context.Context) (ctrl.Result,

namespace, name, uid := folder.Split()

params := folders.NewDeleteFolderParams().WithFolderUID(uid)
reftrue := true
params := folders.NewDeleteFolderParams().WithFolderUID(uid).WithForceDeleteRules(&reftrue)
_, err = grafanaClient.Folders.DeleteFolder(params) //nolint
if err != nil {
var notFound *folders.DeleteFolderNotFound
Expand Down Expand Up @@ -292,7 +293,8 @@ func (r *GrafanaFolderReconciler) onFolderDeleted(ctx context.Context, namespace
if err != nil {
return err
}
params := folders.NewDeleteFolderParams().WithFolderUID(*uid)
reftrue := true
params := folders.NewDeleteFolderParams().WithFolderUID(*uid).WithForceDeleteRules(&reftrue)
_, err = grafanaClient.Folders.DeleteFolder(params) //nolint
if err != nil {
var notFound *folders.DeleteFolderNotFound
Expand Down
131 changes: 131 additions & 0 deletions tests/e2e/force_delete_folder/chainsaw-test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/kyverno/chainsaw/main/.schemas/json/test-chainsaw-v1alpha1.json
apiVersion: chainsaw.kyverno.io/v1alpha1
kind: Test
metadata:
name: force-delete-folders
spec:
concurrent: false
bindings:
- name: USER
value: root
- name: PASS
value: secret
steps:
- name: Create Grafana with testdata resources
try:
- apply:
file: ../testdata-resources.yaml

- assert:
resource:
apiVersion: v1
kind: Pod
metadata:
(contains(name, 'testdata-deployment')): true

- wait:
apiVersion: v1
kind: Pod
timeout: 1m
for:
condition:
name: Ready
value: 'true'

- assert:
resource:
apiVersion: grafana.integreatly.org/v1beta1
kind: Grafana
metadata:
name: testdata
status:
stage: complete
stageStatus: success

- assert:
resource:
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaFolder
metadata:
name: testdata
status:
conditions:
- reason: ApplySuccessful
status: "True"
type: FolderSynchronized

- assert:
resource:
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaAlertRuleGroup
metadata:
name: testdata
status:
conditions:
- reason: ApplySuccessful
status: "True"
type: AlertGroupSynchronized

- name: Ensure folder exists in Grafana
try:
- apply: &curlJob
resource:
apiVersion: batch/v1
kind: Job
metadata:
name: folder-curl
spec:
backoffLimit: 1
template:
spec:
restartPolicy: Never
containers:
- name: curl
image: alpine/curl:latest
command: ["ash", "-c"]
args:
- |
curl --fail --silent --show-error \
-u ${BASIC_USER}:${BASIC_PASS} \
"http://testdata-service.${NS}.svc:3000/api/folders/testdata-uid"
env:
- name: BASIC_USER
value: ($USER)
- name: BASIC_PASS
value: ($PASS)
- name: NS
value: ($namespace)
- assert:
resource:
apiVersion: batch/v1
kind: Job
metadata:
name: folder-curl
status:
(conditions[?type == 'Complete']):
- status: "True"
- delete:
ref:
apiVersion: batch/v1
kind: Job
name: folder-curl

- name: Delete Folder and verify it's removed in Grafana
try:
- delete:
ref:
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaFolder
name: testdata

- apply: *curlJob

- assert:
resource:
apiVersion: batch/v1
kind: Job
metadata:
name: folder-curl
status:
(conditions[?type == 'Failed']):
- status: "True"
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ kind: Test
metadata:
name: dashboards-uids
spec:
concurrent: false
bindings:
- name: dashboardModel
value: |
Expand Down
Loading
Loading