Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot config: Ignore react and react-dom major updates #331

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

idastambuk
Copy link
Contributor

What this PR does / why we need it:

I ran into issues when an update to react 19.0 was submitted in a dependabot PR. Grafana main runs on react@18, so there was a mismatch and subsequent errors. Not sure if there's a better way to do it than this, but we probably dont want to include major updates to react and react-dom in every dependabot PR.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@idastambuk idastambuk requested a review from a team as a code owner December 12, 2024 08:53
@idastambuk idastambuk requested review from iwysiu and njvrzm December 12, 2024 08:53
@idastambuk idastambuk force-pushed the dependabot-ignore-react branch from 43c5cac to 9000257 Compare December 12, 2024 10:11
Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's ignore these until main Grafana moves to v19

@idastambuk idastambuk merged commit 7908a32 into main Dec 16, 2024
6 checks passed
@idastambuk idastambuk deleted the dependabot-ignore-react branch December 16, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants