Full page image: Fix blank page #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -397,7 +398,7 @@ | |||
| }); | |||
| } | |||
|
|
|||
| return page.screenshot({ path: options.filePath, fullPage: options.fullPageImage, captureBeyondViewport: options.fullPageImage || false }); | |||
| return page.screenshot({ path: options.filePath, fullPage: options.fullPageImage, captureBeyondViewport: false }); | |||
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
torkelo
approved these changes
Aug 13, 2024
evictorero
approved these changes
Aug 13, 2024
|
the same thing here |
|
Hi @lsfc02 . Are you still facing the same issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes blank page screenshot bug.
Puppeter resizes the viewport when taking a screenshot. See details here
After this PR in scenes, when taking the screenshot
isMobileis true for a while (randomly). That makes the dashboard re-render and the screenshot ends up being a blank page, showing only the NavToolbar.Issue thread.
With
captureBeyondViewportas false, it works as expected, because we set the viewport based on panels containerscrollHeighthere