Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to plugin V1 protocol #233

Merged
merged 3 commits into from
May 25, 2021

Conversation

AgnesToulet
Copy link
Contributor

@AgnesToulet AgnesToulet commented May 19, 2021

Remove references to plugin V1 protocol as it's not supported anymore by Grafana: see grafana/grafana#33959

Closes #228

Question: I'm not sure if the coreProtocolVersion should be updated as well? It's only displayed when the plugin starts: https://github.com/grafana/grafana-image-renderer/search?q=coreprotocolversion

@AgnesToulet AgnesToulet requested a review from marefr May 20, 2021 13:09
Copy link
Contributor

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things left. Otherwise looks great 👍

plugin.json Outdated Show resolved Hide resolved
src/app.ts Outdated Show resolved Hide resolved
@AgnesToulet AgnesToulet requested a review from marefr May 25, 2021 13:06
Copy link
Contributor

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for deprecated backend plugin protocol version
2 participants