Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timeout opt value for browser page.goto #171

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

w4rgrum
Copy link
Contributor

@w4rgrum w4rgrum commented Aug 14, 2020

Fix #169
page.goto timeout needs to be aligned to query timeout in remote server mode.

@w4rgrum w4rgrum changed the title Use timeout opt value for browser page.goto. Fixes #169 Use timeout opt value for browser page.goto Aug 14, 2020
@daniellee daniellee self-requested a review January 26, 2021 20:43
Copy link
Contributor

@daniellee daniellee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Have tested this with a dashboard with some long-running queries and could recreate the original issue. This PR worked as expected.

@daniellee daniellee merged commit 311abc0 into grafana:master Jan 26, 2021
@mjtrangoni
Copy link

@daniellee this is still not available over grafana-cli. Are you going to add it there? What about the signature? Thanks!

@daniellee
Copy link
Contributor

@mjtrangoni we had some problems publishing the new version due to changes to our publishing pipeline. (The image renderer plugin is so much bigger than all the other plugins and adding plugin signing). Will hopefully have that resolved soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeoutError: Navigation timeout of 30000 ms exceeded
3 participants