Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker packaging needs updated for #239 #247

Closed
mbentley opened this issue Jun 8, 2021 · 2 comments · Fixed by #248
Closed

Docker packaging needs updated for #239 #247

mbentley opened this issue Jun 8, 2021 · 2 comments · Fixed by #248

Comments

@mbentley
Copy link
Contributor

mbentley commented Jun 8, 2021 •
edited
Loading

What happened:
The Dockerfile does not package up plugin.json. I'll submit a PR to fix this shortly.

What you expected to happen:
The /render/version API to work; added in #239.

How to reproduce it (as minimally and precisely as possible):

Start a container

$ docker run -d --name test grafana/grafana-image-renderer:3.0.0

Exec into it:

$ docker exec -it test sh

Install curl and try to hit the version API endpoint:

# apk add curl
# curl localhost:8081/render/version
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>Error</title>
</head>
<body>
<pre>Internal Server Error</pre>
</body>
</html>

Check the logs from the renderer:

$ docker logs test
{"level":"info","message":"HTTP Server started, listening at http://localhost:8081"}
{"message":"::ffff:127.0.0.1 - - [08/Jun/2021:13:56:09 +0000] \"GET /renderer/version HTTP/1.1\" 404 155 \"-\" \"curl/7.77.0\"\n","level":"error"}
{"url":"/render/version","stack":"Error: Cannot find module '../../plugin.json'\nRequire stack:\n- /usr/src/app/build/service/http-server.js\n- /usr/src/app/build/app.js\n    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)\n    at Function.Module._load (internal/modules/cjs/loader.js:730:27)\n    at Module.require (internal/modules/cjs/loader.js:957:19)\n    at require (internal/modules/cjs/helpers.js:88:18)\n    at /usr/src/app/build/service/http-server.js:131:36\n    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)\n    at next (/usr/src/app/node_modules/express/lib/router/route.js:137:13)\n    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:112:3)\n    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)\n    at /usr/src/app/node_modules/express/lib/router/index.js:281:22","level":"error","message":"Request failed"}
{"message":"::ffff:127.0.0.1 - - [08/Jun/2021:13:56:23 +0000] \"GET /render/version HTTP/1.1\" 500 148 \"-\" \"curl/7.77.0\"\n","level":"error"}
TypeError: Cannot read property 'statusCode' of undefined
    at /usr/src/app/build/service/http-server.js:143:46
    at Layer.handle_error (/usr/src/app/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:315:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:335:12)
    at next (/usr/src/app/node_modules/express/lib/router/index.js:275:10)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:127:14)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:97:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:112:3)

Anything else we need to know?:

Environment:

  • Grafana Image Renderer version: 3.0.0
  • Grafana version: 8.0.0
  • Installed plugin or remote renderer service: remote
  • OS Grafana Image Renderer is installed on: n/a
  • User OS & Browser:
  • Others:
mbentley added a commit to mbentley/grafana-image-renderer that referenced this issue Jun 8, 2021
@mbentley
Add plugin.json to the renderer Docker image; fixes grafana#247
4e27653 
Signed-off-by: Matt Bentley <[email protected]>
mbentley added a commit to mbentley/grafana-image-renderer that referenced this issue Jun 8, 2021
@mbentley
Add plugin.json to the renderer Docker image; fixes grafana#247
21731e9 
Signed-off-by: Matt Bentley <[email protected]>
mbentley added a commit to mbentley/grafana-image-renderer that referenced this issue Jun 8, 2021
@mbentley
Add plugin.json to the renderer Docker image; fixes grafana#247
a7c98a5 
Signed-off-by: Matt Bentley <[email protected]>
@AgnesToulet AgnesToulet mentioned this issue Jun 8, 2021
Merged
AgnesToulet pushed a commit that referenced this issue Jun 8, 2021
@mbentley
Add plugin.json to the renderer Docker image; fixes #247 (#248)
44505eb 
Signed-off-by: Matt Bentley <[email protected]>
@Bak-Jin-Hyeong
Copy link

An official docker image that fixes this issue will be pushed soon?

@AgnesToulet
Copy link
Contributor

Yes, the version 3.0.1 released a few days ago includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add plugin.json to the renderer Docker images mbentley/grafana-image-renderer
3 participants
@mbentley @Bak-Jin-Hyeong @AgnesToulet