Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with config select dependencies #20

Merged
merged 4 commits into from
May 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

All notable changes to this project will be documented in this file.

## v0.0.37

- Fix config selector bug for refetching credentials on dependency change.
- Start contributing docs

## v0.0.36

- Expose SIGV4 component
14 changes: 14 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Contributing Docs

## Local Dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's just me but I always forget how to do this so I added it to our docs. Idk if this is really best place for it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's helpful so my +1


Want to install this repo locally?

- In the terminal where this repo is installed: `yarn run dev` or `yarn run build`
- In a terminal navigate to your consumer directory (ex athena) and run `yarn --version`
- if you get a yarn version <2:
- back in aws-sdk run `yarn link` copy the instructions
- run those instructions in the external consumer (athena)
- if you got back a yarn version >2:
sarahzinger marked this conversation as resolved.
Show resolved Hide resolved
- if you get a yarn version >2:
- in consumer package (ex grafana) `yarn link path-to-sdk` it should add a portal resolution to your package.json
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@grafana/aws-sdk",
"version": "0.0.36",
"version": "0.0.37",
"description": "Common AWS features for grafana",
"main": "dist/index.js",
"scripts": {
Expand Down
2 changes: 2 additions & 0 deletions src/sql/ConfigEditor/ConfigSelect.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export function ConfigSelect(props: ConfigSelectProps) {
props.options.jsonData.endpoint,
props.options.jsonData.externalId,
props.options.jsonData.profile,
props.options.secureJsonData?.accessKey,
props.options.secureJsonData?.secretKey,
].concat(props.dependencies);
return (
<ResourceSelector
Expand Down