Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DiffView): Disable AI button when no selections #258

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

grafakus
Copy link
Contributor

@grafakus grafakus commented Nov 5, 2024

✨ Description

Related issue(s): is caused by https://github.com/grafana/explore-profiles/pull/231/files#diff-b648e06443c5667d8938e238e6b0a8b7579e793379e4fdd1cfc0c0191a7984e6R105

A quick fix to properly disable the "Explain Flame Graph" when no selections are made

📖 Summary of the changes

See diff tab

🧪 How to test?

-

@github-actions github-actions bot added the fix label Nov 5, 2024
@grafakus grafakus requested a review from ifrost November 5, 2024 09:04
@grafakus grafakus self-assigned this Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Unit test coverage

Lines Statements Branches Functions
Coverage: 12%
12.34% (486/3937) 9.73% (136/1397) 8.88% (111/1249)

@grafakus grafakus merged commit 58e89cb into main Nov 5, 2024
5 of 6 checks passed
@grafakus grafakus deleted the fix/diff-view-disable-ai-button branch November 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant