Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ServiceNameVariable): Persist last service selected in localStorage #222

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

grafakus
Copy link
Contributor

✨ Description

Related issue(s): -

This PR persists the last service that was selected to localStorage so that, when coming back to the app, it is selected directly.

📖 Summary of the changes

See diff tab.

🧪 How to test?

Manually: going to Explore Profiles, selecting a service, going to (e.g.) a dashboard, then coming back to the app by clicking on the main menu item.

@grafakus grafakus requested review from ifrost and bryanhuhta October 11, 2024 12:15
@github-actions github-actions bot added the feat label Oct 11, 2024
Copy link
Contributor

Unit test coverage

Lines Statements Branches Functions
Coverage: 11%
11.5% (428/3720) 9.06% (120/1324) 8.6% (102/1185)

@grafakus grafakus removed the request for review from bryanhuhta October 11, 2024 12:30
@grafakus grafakus self-assigned this Oct 14, 2024
@grafakus grafakus merged commit 3917660 into main Oct 17, 2024
4 of 5 checks passed
@grafakus grafakus deleted the feat/persist-service branch October 17, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant