Service selection: Showing incorrect list of services after changing datasource on breakdown views #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sues/764/split-it-up
…sues/764/split-it-up
…s down in links.ts
…4/split-it-up__refactor
…4/split-it-up__refactor
…//github.com/grafana/explore-logs into gtk-grafana/issues/764/split-it-up__refactor
…4/split-it-up__refactor
…8/volume-query-not-running
gtk-grafana
changed the title
matyax
reviewed
Oct 10, 2024
matyax
approved these changes
Oct 10, 2024
…8/volume-query-not-running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #808
Updates service selection functionality to always re-run volume query on activation of service selection scene.
This bug was likely introduced with the runtime datasource change.
Ideally there would be a way to know if a dataprovider has changed datasources, and we could only re-run this query when the datasource changed, and otherwise use the cached result if available, but this appears to be a consequence of using a runtime datasource.