Frontend instrumentation #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtk-grafana
commented
Sep 19, 2024
gtk-grafana
commented
Sep 19, 2024
src/Components/ServiceScene/Breakdowns/Patterns/PatternsLogsSampleScene.tsx
Outdated
Show resolved
Hide resolved
gtk-grafana
commented
Sep 19, 2024
src/Components/ServiceScene/Breakdowns/PatternsLogsSampleScene.tsx
Outdated
Show resolved
Hide resolved
gtk-grafana
commented
Sep 19, 2024
src/Components/Table/ColumnSelection/ColumnSelectionDrawerWrap.tsx
Outdated
Show resolved
Hide resolved
gtk-grafana
commented
Sep 19, 2024
| logError(new Error('unknown error'), context); | ||
| } | ||
| } catch (e) { | ||
| console.error('Failed to log faro error!', { err, context }); |
There was a problem hiding this comment.
might be overkill, but I didn't want any runtime errors coming from failing to log something
svennergr
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed our console.errors weren't magically making it into Faro when debugging #788, probably because we weren't sending them 🤦!
This PR attempts to add a runtime safe logging service to replace all console calls that will send frontend telemetry to Faro.
This was done quickly, but we should be asking "is the context in the log enough to adequately debug the problem?" for each log