Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line filter: Case sensitive search #744

Merged
merged 105 commits into from
Sep 11, 2024
Merged

Line filter: Case sensitive search #744

merged 105 commits into from
Sep 11, 2024

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Sep 4, 2024 •
edited
Loading

Fixes: #739

image image

svennergr and others added 30 commits August 28, 2024 08:24
@svennergr
feat(detected-fields): use /detected_fields API
41d5cf1
@gtk-grafana
chore: wip - update panels instead of full body rebuild
4af478d
@gtk-grafana
chore: clean up
4865ed0
@gtk-grafana
Merge remote-tracking branch 'origin/main' into svennergr/detected-fi…
89d45c5 
…elds-new
@gtk-grafana
chore: clean up conflicts, fix bug
985dfff
@gtk-grafana
chore: sort on load
0013df6
@gtk-grafana
test: fix fields unit tests
5df1b73
@gtk-grafana
chore: wip - remove all parser determination logic and hardcode both …
e05ed72 
…parsers
@gtk-grafana
chore: optimize queries
68ac37c
@gtk-grafana
chore: refactor
94a4773
@gtk-grafana
chore: clean up
3f5f171
@gtk-grafana
chore: fix test
5aaf3a5
@gtk-grafana
chore: delete old code
521fe03
@gtk-grafana
chore: wip - move parser to variable value, update label queries on c…
f90626f 
…hange
@gtk-grafana
chore: wip - fixing label name breakdown, filtering out detected_leve…
4447607 
…l from fields
@gtk-grafana
chore: wip - fix memoize bug making panels fail to update
38a15f5
@gtk-grafana
chore: remove fields in response
1f15ab5
@gtk-grafana
chore: always re-run detected-fields on fields slugs activation
9324cd8
@gtk-grafana
chore: remove console.log
1d44a98
@gtk-grafana
fix: fix filter button states
5713234
@gtk-grafana
test: update test
0a9d693
@gtk-grafana
chore: add unit test for datasource
cdcb3f6
@gtk-grafana
test: rehaul tests now that field sort order is less determinate
a4d399b
@gtk-grafana
test: set taller viewport
4db4b29
@gtk-grafana
test: finally find out why that test is flaking
30e971b
@gtk-grafana
test: fix flake
dd03f9a
@gtk-grafana
chore: remove only
f2b95d1
@gtk-grafana
test: fix flake
50efaa4
@gtk-grafana
test: continue flake hunt
82ac915
@gtk-grafana
fix: fix index bug breaking parser on first field
718555d
@gtk-grafana
chore: remove unused function, update tests
83cf916
@gtk-grafana
chore: prettier on test files
9ad946a
@gtk-grafana
chore: test updating lintstage config
fec16d9
@gtk-grafana
chore: add local loki docker compose
698b839
@gtk-grafana
chore: update loki to grafana/loki:k218-85759c7
9a85327
@gtk-grafana
Merge remote-tracking branch 'origin/main' into svennergr/detected-fi…
13025b9 
…elds-new
@gtk-grafana
Merge remote-tracking branch 'origin/main' into svennergr/detected-fi…
1aaf308 
…elds-new
@gtk-grafana
chore: throw console error when detected_fields errs
1b8cdbc
@gtk-grafana
test: add test coverage for mixed json/logfmt service
8d300e3
@gtk-grafana
test: add a bit of wait for requests to fire
6b51c16
@gtk-grafana
test: wait in better spot
e16e8ec
@gtk-grafana
chore: remove only
5975818
@gtk-grafana
chore: remove wait, update assertion
6eb3254
@gtk-grafana
chore: fix structured metadata bug, update loki config to use protobu…
1b9c410 
…f encoding
@gtk-grafana
chore: clean up, fix tests, support null and empty array for metadata
dcba06a
@gtk-grafana
test: fix unit test
dd5fca5
Base automatically changed from svennergr/detected-fields-new to main September 10, 2024 19:21
@gtk-grafana gtk-grafana marked this pull request as ready for review September 11, 2024 12:14
@gtk-grafana gtk-grafana requested a review from a team as a code owner September 11, 2024 12:14
@matyax
Copy link
Contributor

matyax commented Sep 11, 2024

Merged main but it's still showing 108 commits?

@gtk-grafana
Copy link
Contributor Author

Yeah I get paid by the commit :P

But seriously I don't know why it does this, at least we squash branches on merge to main

@matyax
Copy link
Contributor

matyax commented Sep 11, 2024

Not sure if we need to fix this:

imagen

@matyax
Copy link
Contributor

matyax commented Sep 11, 2024

I love how this control looks btw.

matyax
matyax approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what I mentioned in the comment, this works flawlessly.

@gtk-grafana
Copy link
Contributor Author

@matyax created #756 to track adding better UI state for line filter queries that exclude everything.

@gtk-grafana gtk-grafana merged commit c224ec9 into main Sep 11, 2024
4 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/case-sensitive-search branch September 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow case sensitive search
3 participants
@gtk-grafana @matyax @svennergr