Breakdowns: Level, detected level, level_extracted, oh my! #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took the liberty to update the tests and merge, so I can work on top of this. Thank you! |
|
For posterity: theoretically |
|
Good point @svennergr . I think the main objective right now is to be consistent and minimize possible sources of confusion by, for example, having more than one We can come back to this in the future with something smarter if, for example, there's a chance of having |
gtk-grafana
deleted the
gtk-grafana/issues/676/detected-level-in-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #676
The same level panel shows up in several different places in the UI. Let's remove them all except the one that's pushed to the top of the label breakdown.