Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting: add outlier detection as a sorting option #658

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

matyax
Copy link
Contributor

@matyax matyax commented Aug 2, 2024

This PR adds outlier detection to sort value breakdowns. It works by using DBSCAN to detect outlying intervals, and sorting by the detected quantity.

Addtionally, we're wrapping all the WASM invocations, logging the errors and falling back to StdDev when it happens.

@matyax matyax requested a review from a team as a code owner August 2, 2024 15:44
@svennergr
Copy link
Contributor

I think we need to also gate

init().then(() => console.debug('Grafana ML initialized'));
to only init when wasm is supported.

@matyax
Copy link
Contributor Author

matyax commented Aug 2, 2024

Right! Great idea, done.

@matyax matyax requested a review from svennergr August 2, 2024 16:02
Copy link
Contributor

@gtk-grafana gtk-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and working well locally

@matyax matyax enabled auto-merge (squash) August 2, 2024 19:14
@matyax matyax merged commit 073fd51 into main Aug 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants