Value breakdowns: maintain filters between value changes #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if we want to add an action to clear the search in the alert like we have when filters have removed all results? |
|
Oh, definitely. Good idea. |
gtk-grafana
approved these changes
Jul 17, 2024
matyax
force-pushed
the
matyax/value-search-improvements
branch
from
f556760 to
a329c22
Compare
|
I managed to update this PR with the route changes, to support keeping filters between value changes. Next, I would like to double check the combination of sorting + filtering + value changes + layout switcher (single, grid, row) to be sure we're not introducing (or carrying over) any inconsistency. |
|
Double checked for inconsistencies and looks good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
BreakdownSearchScenetoByFrameRepeater.ByFrameRepeaterByFrameRepeaterif has a filter, applies it after "repeating".Closes #559