Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels: Add search box to labels #454

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

gtk-grafana
Copy link
Contributor

Fixes #452

Unified search code as much as possible, also added fuzzy searching to allow for typos and string insensitive matching

@gtk-grafana gtk-grafana marked this pull request as ready for review June 13, 2024 16:55
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

placeholder="Search for value"
/>
{!loading && value !== ALL_VARIABLE_VALUE && search instanceof BreakdownSearchScene && (
<search.Component model={search} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

const labelValue = getLabelValue(frames[seriesIndex]);
haystack.push(labelValue);
});
fuzzySearch(haystack, filter, (data) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@gtk-grafana gtk-grafana enabled auto-merge June 13, 2024 17:49
@gtk-grafana gtk-grafana merged commit 4788380 into main Jun 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search box for Label values
2 participants