Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs Table UI: Legacy dataplane fix #436

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

gtk-grafana
Copy link
Contributor

Adding backwards compatibility for legacy dataplane.
For some reason I thought the dataplane feature was required for the logs app, but I was incorrect.

@gtk-grafana gtk-grafana marked this pull request as ready for review June 11, 2024 14:32
@gtk-grafana gtk-grafana requested review from a team and matyax June 11, 2024 14:32
@gtk-grafana gtk-grafana self-assigned this Jun 11, 2024
@gtk-grafana gtk-grafana added the bug Something isn't working label Jun 11, 2024
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, but code looks good.

src/services/logsFrame.ts Show resolved Hide resolved
@gtk-grafana gtk-grafana merged commit 9449003 into main Jun 11, 2024
3 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/logs-table/legacy-dataplane branch June 11, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants