Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FieldsBreakDownScene): add loading state and empty state #424

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix(FieldsBreakDownScene): add loading state and empty state #424

merged 2 commits into from
Jun 7, 2024

Conversation

matyax
Copy link
Contributor

@matyax matyax commented Jun 7, 2024

Fixes #393

This PR:

  • Adds a missing loading state to Detected Fields
  • Adds an empty state to Detected fields

Message

Demo.mov

@matyax
Copy link
Contributor Author

matyax commented Jun 7, 2024

The "by field" will be gone in #418

gtk-grafana
gtk-grafana approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@gtk-grafana gtk-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd suggest checking with design or docs to double check the new copy in the message

@matyax
Copy link
Contributor Author

matyax commented Jun 7, 2024

Good idea. Last version of this new message:

imagen

@matyax matyax enabled auto-merge June 7, 2024 15:26
@matyax matyax merged commit 3f58da2 into main Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtk-grafana gtk-grafana gtk-grafana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve empty Detected Fields view
2 participants
@matyax @gtk-grafana