Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patterns): only allow a single include pattern #343

Merged
merged 7 commits into from
May 20, 2024
Merged

fix(patterns): only allow a single include pattern #343

merged 7 commits into from
May 20, 2024

Conversation

gtk-grafana
Copy link
Contributor

Fixes: #218

This PR does 2 things:

  1. When a pattern is already excluded, it will hide the exclude pattern button. Same with included patterns
  2. When a pattern is included, all other patterns are removed from state.
patterns-logic-update.mov

@gtk-grafana gtk-grafana self-assigned this May 16, 2024
@gtk-grafana gtk-grafana marked this pull request as ready for review May 20, 2024 13:02
@gtk-grafana gtk-grafana requested a review from a team May 20, 2024 13:02
matyax
matyax approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! I wonder if users will understand that you can only have one active pattern filter active at a given time.

@matyax matyax mentioned this pull request May 20, 2024
Merged
@gtk-grafana gtk-grafana merged commit 4868012 into main May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax approved these changes

Assignees

@gtk-grafana gtk-grafana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a way to indicate when patterns have been added or excluded from the search
2 participants
@gtk-grafana @matyax