Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: Single view #342

Merged
merged 38 commits into from
May 22, 2024
Merged

Patterns: Single view #342

merged 38 commits into from
May 22, 2024

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented May 16, 2024 •
edited
Loading

Fixes: #30

patterns-table-demo.mov

@gtk-grafana gtk-grafana mentioned this pull request May 16, 2024
Closed
@gtk-grafana gtk-grafana changed the base branch from main to gtk-grafana/issues/331/patterns-lazy-load__single-view-poc May 16, 2024 18:01
@gtk-grafana gtk-grafana changed the base branch from gtk-grafana/issues/331/patterns-lazy-load__single-view-poc to main May 20, 2024 20:30
@gtk-grafana gtk-grafana changed the base branch from main to gtk-grafana/issues/218/update-pattern-logic May 20, 2024 20:37
@gtk-grafana gtk-grafana changed the base branch from gtk-grafana/issues/218/update-pattern-logic to main May 20, 2024 20:57
gtk-grafana and others added 13 commits May 20, 2024 15:57
@gtk-grafana
Merge branch 'main' into gtk-grafana/issues/331/patterns-lazy-load__s…
9d92924 
…ingle-view-poc__table
@gtk-grafana
chore(patterns): clean up, comment
54136be
@gtk-grafana
Merge branch 'gtk-grafana/issues/331/patterns-lazy-load__single-view-…
b4c2f51 
…poc__table' of https://github.com/grafana/explore-logs into gtk-grafana/issues/331/patterns-lazy-load__single-view-poc__table
@gtk-grafana
fix(patterns): fix filtering logic on new buttons
a3f10b7
@gtk-grafana
chore: clean up
b9b5d85
@gtk-grafana
fix(patterns): hide include button in table when already included
b24b688
@gtk-grafana
fix: use cloneSceneObjectState to fix scene warning
abd7abb
@gtk-grafana
chore(patterns): implement fixed height for table, clean up
913b9f6
@gtk-grafana
chore(patterns): convert to set
e5a6430
@gtk-grafana
chore(patterns): clean up, refactor, document
c389fdd
@gtk-grafana
chore(patterns): sort legend by total
55d9143
@gtk-grafana
test(patterns): fix existing tests
fb37fcb
@gtk-grafana
test(patterns): add e2e test coverage for new default view
1dcca86
@gtk-grafana gtk-grafana changed the title Patterns: Single view Table POC Patterns: Single view May 21, 2024
@gtk-grafana gtk-grafana marked this pull request as ready for review May 21, 2024 18:30
@gtk-grafana gtk-grafana requested a review from a team May 21, 2024 18:30
@gtk-grafana gtk-grafana self-assigned this May 21, 2024
matyax
matyax reviewed May 22, 2024
View reviewed changes
package.json Show resolved Hide resolved
matyax
matyax reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments for now. Please re-request when it's ready for the final review.

src/Components/ServiceScene/Breakdowns/SingleViewTableScene.tsx Outdated Show resolved Hide resolved
@gtk-grafana gtk-grafana requested a review from matyax May 22, 2024 15:13
matyax
matyax approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! The monospace font in the table is :cheffkiss:

tests/exploreServicesBreakDown.spec.ts Outdated Show resolved Hide resolved
@gtk-grafana gtk-grafana merged commit dae72d4 into main May 22, 2024
3 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/issues/331/patterns-lazy-load__single-view-poc__table branch May 22, 2024 16:26
@gtk-grafana gtk-grafana mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax approved these changes

Assignees

@gtk-grafana gtk-grafana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service detail page: Add **Single** view for **Patterns**
2 participants
@gtk-grafana @matyax