-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenes: Updating to v6 #1019
base: main
Are you sure you want to change the base?
Scenes: Updating to v6 #1019
Conversation
This is currently breaking the entire app 😢 Seems to be getting thrown on this line on the third render:
Error thrown in Grafana
Error thrown when debugging:
|
Yeah, I know 😢 I am looking into it, will get back once I have found the root cause @gtk-grafana 👍 . |
f41f07e
to
1cdaeff
Compare
Hey @gtk-grafana 👋 I have managed to make the app work locally after doing some more updates, and the tests pass as well now. (The PR is not ready, as there are still a few temporary Please let me know if you encounter any issues. 🙏 |
@leventebalogh everything seems to work as expected, I removed the ts-ignores.
Deleting node_modules and re-installing doesn't seem to fix. |
Note
This is PR in its current form is mostly for demonstration purposes, I would leave the final touches and the merging to the @grafana/observability-logs team (of course happy to help in case there are any questions or issues).
What changed?
This PR updates to use scenes
v6.0.0
.Notes for the reviewers
Please keep in mind that the PR is still depending on the canary version, which should be updated before merged. There are also a few temporary
@ts-ignore
statements that needs to be fixed before merging.