cache: Add .Set and .Add methods to cache clients
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
56quarters/more-cache-methods
branch
from
8b287e3 to
2f51483
Compare
This change adds a synchronous version of `.Set` to Memcached and Redis clients as well as the various `Cache` wrapper implementations. This allows callers to set a key and be sure it exists in the cache. This change also adds an `.Add` method which conditionally adds an item to the cache only if it does not already exist. This change is a prerequisite for grafana/mimir#9386 Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
force-pushed
the
56quarters/more-cache-methods
branch
from
2f51483 to
ebcbf7b
Compare
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Oct 3, 2024
Proof-of-concept for discussion as part of: #9434 grafana/dskit#591 Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Oct 3, 2024
Proof-of-concept for discussion as part of: #9434 grafana/dskit#591 Signed-off-by: Nick Pillitteri <[email protected]>
This was referenced Oct 3, 2024
Signed-off-by: Nick Pillitteri <[email protected]>
dimitarvdimitrov
approved these changes
Oct 4, 2024
Comment on lines
+124
to
+127
| // When a caller uses the Add method, the presence of absence of an entry in the cache | ||
| // has significance. In order to maintain the semantics of that, we only add an entry to | ||
| // the LRU when it was able to be successfully added to the shared cache. | ||
| if err == nil { |
There was a problem hiding this comment.
i didn't think of this. Can you add a tiny test for it?
There was a problem hiding this comment.
Good idea, will do 👍
When you give Memcached a TTL longer than 30d, it treats the number of seconds as a Unix timestamp. E.g. if you give it a 31d TTL your item will expire on February 1st 1970 -- immediately. |
Signed-off-by: Nick Pillitteri <[email protected]>
5 tasks
Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Oct 7, 2024
Specifically, this pulls in grafana/dskit#591 which adds new `.Set()` and `.Add()` methods to cache interfaces and clients. Signed-off-by: Nick Pillitteri <[email protected]>
4 tasks
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Oct 7, 2024
Specifically, this pulls in grafana/dskit#591 which adds new `.Set()` and `.Add()` methods to cache interfaces and clients. Signed-off-by: Nick Pillitteri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This change adds a synchronous version of
.Setto Memcached and Redis clients as well as the variousCachewrapper implementations. This allows callers to set a key and be sure it exists in the cache. This change also adds an.Addmethod which conditionally adds an item to the cache only if it does not already exist.Which issue(s) this PR fixes:
This change is a prerequisite for grafana/mimir#9386
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]