ring: Add DoUntilQuorum method #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added an example of how this would be used to Mimir: grafana/mimir@70e788c |
pracucci
approved these changes
May 12, 2023
…allocations in Do that doesn't use context functionality
|
Still LGTM! Thanks for addressing feedback. |
7 tasks
trevorwhitney
added a commit
to grafana/loki
that referenced
this pull request
Aug 23, 2023
This changes the forGivenIngestors function in pkg/querier/ingester_querier.go to use `DoUntilQuorum` (from [PR #293](grafana/dskit#293)) instead of `Do`. `DoUntilQuorum` is much more efficient than `Do`. The exact differences between them can be seen [here](grafana/dskit#293). --------- Co-authored-by: Trevor Whitney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds a
DoUntilQuorummethod to theringpackage.In contrast to the existing
ReplicationSet.Domethod,DoUntilQuorumhas the following behaviour differences:DoUntilQuorumdoes not support delaying invocations offDoUntilQuorumsupports cleaning up results that will not be returned, including results that arrive afterDoUntilQuorumreturns, making it easier to ensure that resources are not leakedDoUntilQuorumimmediately cancels the context passed toffor any invocations we know will are no longer necessary (eg. because other calls in the same zone have already failed)DoUntilQuorumdoes not cancel the context passed tofif the result is returned, which is useful for scenarios whereDoUntilQuorumis used to establish a set of streams that will continue afterDoUntilQuorumreturnsDoUntilQuorumonly returns the minimum set of results required for quorumThis last point is best explained with an example. Imagine we have three zones each with two instances, we tolerate one unavailable zone and the results from each instance arrive in this order:
ReplicationSet.Dowould return results from all five instances, whereasDoUntilQuorumwill only return the results from the instances in zones A and B and cleanup the results from zone C, including the result from instance 2 in zone C if it arrives.Which issue(s) this PR fixes:
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]