Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Grafana Memcached client fork instead of upstream #248

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented Jan 3, 2023

Signed-off-by: Nick Pillitteri [email protected]

What this PR does:

Switch uses of bradfitz/gomemcache to grafana/gomemcache to incorporate changes and improvements not available upstream.

Which issue(s) this PR fixes:

See grafana/gomemcache#8
See grafana/mimir#3772

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@56quarters 56quarters force-pushed the 56quarters/memcached-dep branch from aeb00d8 to f8b9022 Compare January 4, 2023 18:52
@56quarters 56quarters marked this pull request as ready for review January 4, 2023 18:52
@56quarters 56quarters merged commit 356662f into main Jan 4, 2023
@56quarters 56quarters deleted the 56quarters/memcached-dep branch January 4, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants