Pre-compute aggregations to optimize scaling recording rules #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
1 task
tomwilkie
reviewed
Mar 30, 2021
tomwilkie
reviewed
Mar 30, 2021
| ) | ||
| )[24h:5m] | ||
| ) | ||
| quantile_over_time(0.99, cluster_namespace_deployment:container_memory_usage_bytes:sum[24h:5m]) |
beorn7
requested changes
Mar 30, 2021
Signed-off-by: Marco Pracucci <[email protected]>
|
Thanks @beorn7 for your detailed reply. I see your point. I removed the |
tomwilkie
approved these changes
Mar 31, 2021
beorn7
approved these changes
Mar 31, 2021
|
Let's see how it works out. |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…ecording-rules Pre-compute aggregations to optimize scaling recording rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Based on feedback received in #283 (comment), in this PR I'm proposing to pre-compute aggregations to try to optimize the scaling recording rules.
I haven't splitted recording rules into multiple groups in this PR in order to keep the diff easier to review.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]