Fixed "Disk Writes" and "Disk Reads" panels #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
gouthamve
approved these changes
Mar 23, 2021
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…isk-panels Fixed "Disk Writes" and "Disk Reads" panels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The "Disk Writes" and "Disk Reads" panels are showing incorrect numbers because we currently sum
node_disk_written_bytes_totalandnode_disk_read_bytes_totalmetrics by device only and not by device + node, so basically if a pod is usingsdbwe show the sum ofsdbacross all nodes.This PR fixes it (I've manually tested it in our infra).
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]