Increased CortexRequestErrors alert severity #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
jtlisi
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
I'm 100% on board with this change. Before the the SLO alerts were added this alert was critical. One issue with the SLO alerts is it's difficult to tel if it was triggered by latency or errors. That means you can't really silence it for an intractable latency issue without being concerned an error issue could trigger later. This alert helps fill the gap.
pstibrany
approved these changes
Apr 9, 2021
gouthamve
approved these changes
Apr 20, 2021
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…ortex-request-error-level Increased CortexRequestErrors alert severity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The
CortexRequestErrorsalert looks to be quite critical. If it triggers, it means > 1% of requests to a specific route are failing for 15 consecutive minutes.What's the sentiment if we raise it to
critical?Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]