Add overrides exporter #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
add-overrides-exporter
branch
from
7ff1366 to
bf06d1d
Compare
jdbaldry
approved these changes
Oct 9, 2020
cortex/config.libsonnet
Outdated
| // this enables overrides exporter, which will expose the configured | ||
| // overrides and presets (if configured). Those metrics can be potentially | ||
| // high cardinatilty. | ||
| overrides_exporter_enabled:: false, |
There was a problem hiding this comment.
I think we probably want to avoid this bool for enabling the exporter and instead document how users can import it if they want it. It saves the repeated if enabled then logic that you have to do for each object which is nice.
There was a problem hiding this comment.
You can take a look at this updated version, I basically followed the test exporter with the setup before.
Not too sure how and where to document it, I think right now there is not much docs or am I missing something?
simonswine
force-pushed
the
add-overrides-exporter
branch
2 times, most recently
from
d19c703 to
fad3308
Compare
jtlisi
approved these changes
Oct 10, 2020
cortex/overrides-exporter.libsonnet
Outdated
| local name = 'overrides-exporter', | ||
|
|
||
| _config+: { | ||
| // overrides exporter can also make the previously defined presets available, this list references the |
There was a problem hiding this comment.
Did this sentence get cut off?
There was a problem hiding this comment.
Good point, fixed it
Overrides exporter part of grafana/cortex-tools and exposes runtime overrides and related presets of Cortex as metrics. Signed-off-by: Christian Simon <[email protected]>
simonswine
force-pushed
the
add-overrides-exporter
branch
from
fad3308 to
3b391b6
Compare
simonswine
added a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2021
…rrides-exporter Add overrides exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add overrides exporter deployment (which is part of grafana/cortex-tools) that exposes runtime
overrides and related presets.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]