Switch store-gateway StatefulSets to Parallel Pod Management #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
Jul 2, 2020
|
Ohhh nice find! |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2021
…re-gateway-to-parallel-pod-management Switch store-gateway StatefulSets to Parallel Pod Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatefulSets support two pod management policies:
OrderedReady(default)ParallelWhen using
Parallelrolling updates are still managed 1-by-1 (likeOrderedReady) but scale up/down are parallel. This means that in the event of a cluster cold start, store-gateway instances can be started all at once instead of waiting 1-by-1.I've done several manual tests in our test cluster and
Parallellooks working fine. Manual tests done:IMPORTANT: the pod management policy is one of these settings that cannot be changed to an existing StatefulSet. This means that to apply these changes the StatefulSet must be deleted and re-created, causing a (short) outage in the read path. Considering the blocks storage is not production ready yet, I would suggest to fix this pod management policy now instead of living with some unwanted legacy.