Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually include the ruler #112

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Actually include the ruler #112

merged 2 commits into from
Jun 25, 2020

Conversation

amckinley
Copy link
Contributor

@amckinley amckinley commented Jun 25, 2020

Not sure why this wasn't included in the example... Adds a dependency on this library and sets the default config similarly to the existing defaults.

Also updates the name of a deprecated config option.

cortex/config.libsonnet Show resolved Hide resolved
cortex/cortex.libsonnet Show resolved Hide resolved
Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those who don't want to run the ruler, they can simply patch in

{
  ruler_deployment:{},
  ruler_service:{},
}

@amckinley amckinley requested a review from a team as a code owner June 25, 2020 10:50
@tomwilkie
Copy link
Contributor

(rebase&push to trigger CI)

@tomwilkie tomwilkie merged commit a831c0a into grafana:master Jun 25, 2020
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants