Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Compute: Implement refresh for pricing map #56

Closed
Tracked by #5
Pokom opened this issue Dec 18, 2023 · 0 comments · Fixed by #59
Closed
Tracked by #5

Google Compute: Implement refresh for pricing map #56

Pokom opened this issue Dec 18, 2023 · 0 comments · Fixed by #59

Comments

@Pokom
Copy link
Contributor

Pokom commented Dec 18, 2023 •
edited
Loading

In the Google's Compute module, we do not implement refreshing the pricing map. Entrypoint is here: https://github.com/grafana/cloudcost-exporter/blob/main/pkg/google/compute/compute.go#L197

We should have some mechanism to refresh the pricing map. This should be configurable so that we can test our locally with a 1 minute configuration, and have a more reasonable 72hr refresh interval in production.
@Pokom Pokom mentioned this issue Dec 18, 2023
Closed
Pokom added a commit that referenced this issue Dec 18, 2023
@Pokom
feat(google): Set refresh interval for compute module
66e36ee 
This alters the `collector.Collect` method on the compute module to
also check if the pricing map needs to be refreshed. This is a
configurable paramater so that folks that want a tighter refresh
interval are easily able to do it.

- closes #56
@Pokom Pokom mentioned this issue Dec 18, 2023
Merged
@Pokom Pokom closed this as completed in #59 Dec 19, 2023
Pokom added a commit that referenced this issue Dec 19, 2023
@Pokom
feat(google): Set refresh interval for compute module (#59)
b14025f 
This alters the `collector.Collect` method on the compute module to also check if the pricing map needs to be refreshed. This is a configurable paramater so that folks that want a tighter refresh interval are easily able to do it.

- closes #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(google): Set refresh interval for compute module grafana/cloudcost-exporter
1 participant
@Pokom